[Rpm-maint] [rpm-software-management/rpm] Fixup few issues found by PVS (#1054)

Panu Matilainen notifications at github.com
Thu Feb 6 11:58:00 UTC 2020


Um, thanks but no thanks.

The code is not *wrong* in any of these cases, so these are not actually fixing anything at all.
PVS chatters a lot about things that are considered rpm coding style (such as setting pointers to NULL on free), and we're *not* going through major plastic surgery every time some new static checker appears on the block. 

Lets address the actual bugs it found instead. There are more than a handful.

P.S. In any case the files.c change would have to be in its own commit, its large a scary-looking even if might not be that. I'd much rather see a patch that refactors it into a helper function, that'd be a far more useful thing to do.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1054#issuecomment-582871820
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200206/ea5cd6aa/attachment.html>


More information about the Rpm-maint mailing list