[Rpm-maint] [rpm-software-management/rpm] Use autodetect for _minimize_writes and _flush_io (#1066)

Panu Matilainen notifications at github.com
Thu Feb 13 12:23:07 UTC 2020


pmatilai commented on this pull request.



>  
 # Set to 1 to flush file IO during transactions (at a severe cost in
-# performance for rotational disks)
-#%_flush_io	0
+# performance for rotational disks). Set to -1 for enabling when running on
+# SSDs. Set to 0 for always off.
+%_flush_io	-1

Same issue as with minimize_writes, the value of the macro is used as-is in fsm so any non-zero value will enable.
Which is probably equally wrong for both macros.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1066#pullrequestreview-358174035
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200213/10ab4f6a/attachment.html>


More information about the Rpm-maint mailing list