[Rpm-maint] [rpm-software-management/rpm] Make "%patchlist -f patches" work. v2 (#1043)

Florian Festi notifications at github.com
Mon Feb 17 10:21:40 UTC 2020

> Do you have a case where the STRIP_TRAILINGSPACE thing actually makes a difference?
> As commit [b7d4277](https://github.com/rpm-software-management/rpm/commit/b7d427728b8ba8734ba47d51849a5736bdd727cd) where readManifest() is added notes:
> > STRIP_TRAILINGSPACE is a bit misleading here as it actually affects whether a newline is added or not, but that's kind of consistent how its used elsewhere.
> There never was any handling for trailing spaces (beyond the newline) in the originating readFilesManifest() either, so I'm dubious.

Yes, without the patch the lines contain the trailing new line. readFileManifest strips them manually, so it does not depend on readManifest doing that. For the stringBuffer those newlines are added back (when STRIP_TRAILINGSPACE is set) as they are used as separators. But without stripping them first they get doubled.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200217/4e1c42fd/attachment.html>

More information about the Rpm-maint mailing list