[Rpm-maint] [rpm-software-management/rpm] More fpLookupSubdir cleanups (#1071)

Panu Matilainen notifications at github.com
Wed Feb 19 11:02:20 UTC 2020


This crashes at the "reinstall 1" test with the following (from valgrind):

> fprint.c:262:12: runtime error: member access within null pointer of type 'const struct fingerPrint'
==943715== Invalid read of size 4
==943715==    at 0x4923867: fpHashFunction (fprint.c:262)
==943715==    by 0x492777D: rpmFpHashAddEntry (rpmhash.C:168)
==943715==    by 0x4929D42: fpCachePopulate (fprint.c:515)
==943715==    by 0x49958BF: rpmtsPrepare (transaction.c:1464)
==943715==    by 0x49964CE: rpmtsRun (transaction.c:1721)
==943715==    by 0x4973989: rpmcliTransaction (rpminstall.c:291)
==943715==    by 0x4977A99: rpmInstall (rpminstall.c:632)
==943715==    by 0x10C6C9: main (rpm.c:265)
==943715==  Address 0xc is not stack'd, malloc'd or (recently) free'd

I guess the second loop will also need to be changed to look at only added packages, or something.

For an easy reproducer outside the test-suite:
> [root at lumikko-w rpm]# ./rpm -U --nodeps --ignorearch --root /srv/test tests/data/RPMS/hello-2.0-1.i686.rpm 
[root at lumikko-w rpm]# ./rpm --reinstall --nodeps --ignorearch --nodocs --root /srv/test/ tests/data/RPMS/hello-2.0-1.i686.rpm


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1071#issuecomment-588163632
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200219/34804e43/attachment.html>


More information about the Rpm-maint mailing list