[Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Only add setuptools requirement for egg-info … (#973)

[Gordon Messmer]

gordonmessmer commented on this pull request.



> @@ -178,8 +178,10 @@
                             depsextras.remove(dep)
                 deps = depsextras
             # console_scripts/gui_scripts entry points need pkg_resources from setuptools
-            if (dist.get_entry_map('console_scripts') or
-                    dist.get_entry_map('gui_scripts')):
+            if ((dist.get_entry_map('console_scripts') or
+                     dist.get_entry_map('gui_scripts')) and
+                    (lower.endswith('.egg') or

I *think* so... If I "bdist_egg" the molecule package, and then install the resulting egg, the console_script is installed.  However, I don't get useful results from this script on egg files.  I'm unclear on whether we ever package egg (or wheel) files, so I'm not actually sure whether that's something that needs to be reviewed and fixed, or dropped.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/973#discussion_r362623655
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200102/5dabd6f0/attachment.html>