[Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

Neal Gompa (ニール・ゴンパ) notifications at github.com
Tue Jan 28 22:34:25 UTC 2020


Conan-Kudo requested changes on this pull request.



> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags pkgFlags,
 			int didInstall, int test)
 {
     Package pkg;
-    rpmRC rc = RPMRC_OK;
+    rpmRC res = RPMRC_OK;

This seems like gratuitous renaming of variables. Is there a reason you did this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1020#pullrequestreview-349753123
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200128/eb3d1eeb/attachment.html>


More information about the Rpm-maint mailing list