[Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

Florian Festi notifications at github.com
Tue Jul 21 11:12:26 UTC 2020


I really like the idea of offering some easier to use API and using an context manager for that. But there are several aspects of this implementation that don't quite feel right to me.

At first I wonder if we can find a better name for the class. This actually wraps (binary) packages. Not sure if `Package` is too generic but it is much closer to the truth.

Abbreviating `archive` with `arch` is super confusing as `arch` is used everywhere else as synonym of `architecture`.

The fd used should really be stay hidden inside the class. Using it else where will only lead to tears and broken bones.

Not sure if `iterFiles` is really needed or if it is better to point to directly using the .archive attribute in the doc string. Or may be I am missing something here.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661792867
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200721/9a66fdf0/attachment.html>


More information about the Rpm-maint mailing list