[Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
Panu Matilainen
notifications at github.com
Wed Jun 10 10:03:22 UTC 2020
@pmatilai commented on this pull request.
> + if (dbus_error_is_set(&err)) {
+ //fprintf(stderr, "Name Error (%s)\n", err.message);
+ dbus_error_free(&err);
+ }
+ if (DBUS_REQUEST_NAME_REPLY_PRIMARY_OWNER != rc) {
+ dbus_connection_close(state->bus);
+ dbus_connection_unref(state->bus);
+ state->bus = NULL;
+ state->logging = 0;
+ return RPMRC_NOTFOUND;
+ }
+ return RPMRC_OK;
+ }
+ }
+
+ return RPMRC_NOTFOUND;
The return code logic is confusing, with multiple returns in space of just a few lines.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#pullrequestreview-427904266
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200610/da0830d9/attachment.html>
More information about the Rpm-maint
mailing list