[Rpm-maint] [rpm-software-management/rpm] Support ed25519 signatures (#1202)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -168,7 +169,8 @@ typedef enum pgpPubkeyAlgo_e {
     PGPPUBKEYALGO_EC		= 18,	/*!< Elliptic Curve */
     PGPPUBKEYALGO_ECDSA		= 19,	/*!< ECDSA */
     PGPPUBKEYALGO_ELGAMAL	= 20,	/*!< Elgamal */
-    PGPPUBKEYALGO_DH		= 21	/*!< Diffie-Hellman (X9.42) */
+    PGPPUBKEYALGO_DH		= 21,	/*!< Diffie-Hellman (X9.42) */
+    PGPPUBKEYALGO_EDDSA		= 22	/*!< EdDSA */

Hmm, this ID isn't officially approved AFAICT, I was only able to find this draft: https://datatracker.ietf.org/doc/draft-ietf-openpgp-rfc4880bis/?include_text=1

If you have another source of information that actually confirms the ID reservation, please add a pointer (to the commit message). Or does being in a draft somehow protect the reservation (I'm not that familiar with IETF processes)? Not sure we should add this as long as it's not official (although since we're not actually generating such content, maybe its not that big a deal)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1202#pullrequestreview-418160205
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200526/667b5903/attachment.html>