[Rpm-maint] [rpm-software-management/rpm] RPM fsverity support (#1203)

Panu Matilainen notifications at github.com
Tue May 26 13:12:17 UTC 2020


@pmatilai commented on this pull request.



> @@ -430,6 +438,10 @@ typedef enum rpmSigTag_e {
     RPMSIGTAG_SHA256	= RPMTAG_SHA256HEADER,
     RPMSIGTAG_FILESIGNATURES		= RPMTAG_SIG_BASE + 18,
     RPMSIGTAG_FILESIGNATURELENGTH	= RPMTAG_SIG_BASE + 19,
+    RPMSIGTAG_VERITYSIGNATURES		= RPMTAG_SIG_BASE + 20,
+    RPMSIGTAG_VERITYSIGNATURELENGTH	= RPMTAG_SIG_BASE + 21,
+    RPMSIGTAG_VERITYSIGNATUREALGO	= RPMTAG_SIG_BASE + 22,
+    RPMSIGTAG_VERITYSIGNATUREBLKSZ	= RPMTAG_SIG_BASE + 23,

The other thing here is: do we really need all these tags? Isn't length easily calculable from the actual signature, and does the block size actually matter for rpm? As in, can we not just decide that we use 4096 as the page size for rpm's purposes and that's it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1203#discussion_r430400205
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200526/082a02ac/attachment.html>


More information about the Rpm-maint mailing list