[Rpm-maint] [rpm-software-management/rpm] RPM fsverity support (#1203)

[Panu Matilainen]

@pmatilai commented on this pull request.



> + * Copyright (C) 2020 Facebook
+ *
+ * Author: Jes Sorensen <jsorensen at fb.com>
+ */
+
+#include "system.h"
+
+#include <rpm/rpmlib.h>		/* RPMSIGTAG & related */
+#include <rpm/rpmlog.h>		/* rpmlog */
+#include <rpm/rpmfi.h>
+#include <rpm/rpmpgp.h>		/* rpmDigestLength */
+#include "lib/header.h"		/* HEADERGET_MINMEM */
+#include "lib/header_internal.h"
+#include "lib/rpmtypes.h"	/* rpmRC */
+#include <libfsverity.h>
+#include <rpmio/rpmio_internal.h>

Always use "..." when including internal-only headers, like you're doing with the others. And the libfsverity.h include should be moved outside the group of rpm's own includes to have it stand out a bit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1203#pullrequestreview-418308520
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200526/4c35590b/attachment.html>