[Rpm-maint] [rpm-software-management/rpm] Simplify & unhackify dependency generator command construction (#1424)

Panu Matilainen notifications at github.com
Thu Nov 5 09:41:47 UTC 2020


Despite ultimately having the same exact options and arguments, parametric
and non-parametric generators receive them in such different manners that
trying to handle them together only makes things more complicated.
Pass the main macro name around and let the runFoo() calls construct
the arguments as fits the case.

This also lets us take advantage of rpmExpandThisMacro() for calling
parametric generators, eliminating the need for the %1 macro argument
hack.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1424

-- Commit Summary --

  * Simplify & unhackify dependency generator command construction

-- File Changes --

    M build/rpmfc.c (50)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1424.patch
https://github.com/rpm-software-management/rpm/pull/1424.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1424
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201105/e21d4db6/attachment.html>


More information about the Rpm-maint mailing list