[Rpm-maint] [rpm-software-management/rpm] debugedit: Distinguish files from directories in src list file (#1436)

Mark Wielaard mark at klomp.org
Tue Nov 17 12:56:55 UTC 2020

Hi Vitalio,

On Sun, 2020-11-15 at 12:35 -0800, Vitalio wrote:
> BTW. How does this help you speed things up?
> We do just `grep -v '/$' to filter directories from source list[1], instead of loop similar to `while read f; do test -d $f || echo $f; done` which takes more than 15 seconds on kernel package.
>  [1] http://git.altlinux.org/people/vt/packages/?p=rpm-build.git;a=commitdiff;h=623707e72815

aha, you have a separate process-debuginfo and find-debuginfo-files
script that I assume replaces the upstream find-debuginfo.sh script.
Yours seem much simpler than what we have in find-debuginfo.sh, which
has grown support for dwz, mini-symtab, etc. Might it be an idea to
split find-debuginfo.sh upstream and adopt/merge your scripts?

BTW. I gave you bad advice, p[0] is after the last character written,
so will always be the zero string terminator because we now use
strlen() - 1. It should have been *(p-1) != '/'. Which should always
work because we filter out zero length strings in the if statement
before the block, so there is always  at least one (last) character.
Sorry about that.



More information about the Rpm-maint mailing list