[Rpm-maint] [rpm-software-management/rpm] Require everything in buildroot to be packaged (#994) (#1442)

Panu Matilainen notifications at github.com
Wed Nov 18 08:22:24 UTC 2020

The intent of %exclude was always to merely support sub-packaging with
wildcards in %files sections, not to permit leaving junk in the buildroot.
Enforce this by checking against the actually packaged contents rather
than everything we encountered during collection. This also gets rid
of the ugly static check_fileList buffer - besides being ugly, such things
are bad for parallelism.

This has been widely abused so the change is likely to break quite a few
packages in the wild. As a side-effect this also cures a long-standing bug
where unpackaged excluded files leak their debuginfo into packaged contents,
as such a package will now fail to build at (RhBug:878863)

Fixes: #994
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Require everything in buildroot to be packaged (#994)

-- File Changes --

    M build/files.c (36)
    M tests/data/SPECS/hlinktest.spec (8)
    M tests/data/SPECS/test-subpackages-exclude.spec (11)
    M tests/rpmbuild.at (37)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201118/0ac0fcd1/attachment.html>

More information about the Rpm-maint mailing list