[Rpm-maint] [rpm-software-management/rpm] Unify builtin and user-defined parametric macro calling syntax (#1434)

Michael Schroeder notifications at github.com
Wed Nov 25 22:41:07 UTC 2020


The handling of "parse" type builtins is kind of weird. I would prefer to have the parsing outside of doExpandThisMacro() so that I can set args to [ "foo", "bar" ] and expand the %define macro to do a `%define foo bar`

We only have 5 builtin macros that are "parse" type: define, global, undefine, dnl, dump
So this doesn't matter much and splitting the parsing from the processing is probably not worth the hassle. (Btw, the parsing of the undefine and dump macros is quite weird.)

With other words: Ok from my side. Feel free to ignore my ramblings ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1434#issuecomment-733977053
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201125/35f22665/attachment.html>


More information about the Rpm-maint mailing list