[Rpm-maint] [rpm-software-management/rpm] Fix Fseek for offset > 2GiB (#1381)

Panu Matilainen notifications at github.com
Thu Oct 8 08:56:09 UTC 2020


@pmatilai commented on this pull request.



> @@ -382,7 +382,7 @@ static ssize_t fdWrite(FDSTACK_t fps, const void * buf, size_t count)
 
 static int fdSeek(FDSTACK_t fps, off_t pos, int whence)
 {
-    return lseek(fps->fdno, pos, whence);
+    return (lseek(fps->fdno, pos, whence)) == -1 ? -1 : 0;

Sorry but that's still not right. There's no point having the extra parenthesis there unless the equality test is inside them. See my previous comment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1381#pullrequestreview-504567241
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201008/99180ffc/attachment.html>


More information about the Rpm-maint mailing list