[Rpm-maint] [rpm-software-management/rpm] Implement alternative transaction callback style (#1365)

Panu Matilainen notifications at github.com
Mon Sep 21 08:07:40 UTC 2020


To clarify, in the C API the only change is the first callback-argument changing from a header to rpmte, ie (rpmte, what, amount, total, key, userdata). Key is redundant and could be dropped, because you can trivially get it from the rpmte now, but that would make this much more complicated for little to no gain, so leaving it alone.

The Python callback is a very different animal. Previously it got (what, amount, total, pkgObj, userdata) as arguments, with pkgObj being either rpmteKey(), RPMTAG_NAME string or None. In this (draft) version, that becomes: (rpmte, what, amount, total, userdata), ie almost the same as C API. The question is whether we should make it the equivalent of the C API, ie with a "key" argument. It's redundant, so I'd kinda prefer to drop it from this new API, but then here's a chance to stop the forever old confusion due to Python and C callback being different...

Thoughts?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1365#issuecomment-695966117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200921/544885a5/attachment.html>


More information about the Rpm-maint mailing list