[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

torsava notifications at github.com
Tue Sep 22 14:41:56 UTC 2020


> Latest push now has every test successfully run the script, however that one test still fails because there's a difference in behaviour between the script in this repo and in python-rpm-generators.
> 
> ```
> -        if '>' == operator:
> -            # distutils does not behave this way, but this is
> -            # their recommendation
> -            # https://mail.python.org/archives/list/distutils-sig@python.org/thread/NWEQVTCX5CR2RKW2LT4H77PJTEINSX7P/
> +        if operator == '>':
> +            # distutils will allow a prefix match with '>'
>              operator = '>='
> -            version.increment()
> +        if operator == '<=':
> +            # distutils will not allow a prefix match with '<='
> +            operator = '<'
> ```
> 
> The differences in that block are the cause of the test failure as far as I can work out.

I believe the behaviour has been changed and you have the new correct version, but I'll double check.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#issuecomment-696766915
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200922/d6e557e5/attachment-0001.html>


More information about the Rpm-maint mailing list