[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

Steve Kowalik notifications at github.com
Wed Sep 23 02:15:33 UTC 2020


@s-t-e-v-e-n-k commented on this pull request.



> -                        dep_normalized_name = dep.key
+                        dep_normalized_name = dep.name.lower().replace('_', '-')
 
                     if args.legacy:
-                        name = 'pythonegg({})({})'.format(pyver_major, dep.key)
+                        name = 'pythonegg({})({})'.format(pyver_major, dep.name.lower())

Because dep.key is from setuptools' pkg_resources.Requirement and packaging.Requirement does not include it -- I'm not against creating a subclass of packing.Requirement here and including a key property that returns self.name.lower()

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#discussion_r493154379
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200922/3149e134/attachment.html>


More information about the Rpm-maint mailing list