[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

Miro Hrončok notifications at github.com
Thu Sep 24 09:35:15 UTC 2020


@hroncok commented on this pull request.



>                      else:
-                        dep_normalized_name = dep.key
+                        dep_normalized_name = dep.key.replace('_', '-')

The code allows both naming conventions. We need to preserve that. ideally, we would have our own regexes for that to avoid changes based on 3rd party changes. We have `normalize_name()` function. What about having `normalize_name(kind="legacy"/"pep503")`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#discussion_r494174964
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200924/68b218ce/attachment.html>


More information about the Rpm-maint mailing list