[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

torsava notifications at github.com
Thu Sep 24 11:01:59 UTC 2020


@torsava commented on this pull request.



>                      if normalized_names_require_pep503:
-                        dep_normalized_name = normalize_name(dep.project_name)
+                        dep_normalized_name = normalize_name(dep.name)
                     else:
                         dep_normalized_name = dep.key

> Be careful with manual replaces for normalized names. There are two regexes that this code supported before. The PEP 503 regex and the regex imported from setuptools (described in here).

I wasn't exactly sure what you meant by this comment, so I asked if the new code looks good to you to be sure.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#discussion_r494224179
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200924/1ff0c1a9/attachment-0001.html>


More information about the Rpm-maint mailing list