[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

torsava notifications at github.com
Thu Sep 24 11:14:56 UTC 2020


@torsava commented on this pull request.



>  from warnings import warn
 
+try:
+    from importlib.metadata import PathDistribution
+except ImportError:
+    from importlib_metadata import PathDistribution
+
+try:
+    from pathlib import Path
+except ImportError:
+    from pathlib2 import Path
+
+
+class Req(Requirement):
+    @property
+    def key(self):
+        return self.name.lower().replace('_', '-')

To clarify a possible confusion, I think `key` always returned the same thing. But this script had two modes, in legacy mode it used the `key` value, and in pep503 mode it used the `normalize_name` function.

So yes, there are two different methods to convert the name, but that is handled by this script, not by `Requirement.key`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#discussion_r494230415
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200924/5d0ff956/attachment.html>


More information about the Rpm-maint mailing list