[Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

Panu Matilainen notifications at github.com
Wed Apr 7 09:04:09 UTC 2021


Most packages execute their %check in the build directory, following
the spirit of autotools "make check" target. However as %check as
actually executes after %install rather than %build, it gives the
impression that you might want to run tests in the buildroot instead,
with the risk of affecting the packaged content.

Move the %check execution before %install to eliminate any ambiguosity
on the subject. This will break any packages relying on builroot
contents, but at least it's a clean break, and installation can always
be simulated by doing this in %check start to a private temporary root
in the build directory, eg ${PWD}/_check.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1618

-- Commit Summary --

  * Clarify %check script use-case by executing it before %install

-- File Changes --

    M build/build.c (10)
    M doc/manual/spec.md (3)
    M doc/rpmbuild.8 (6)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1618.patch
https://github.com/rpm-software-management/rpm/pull/1618.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210407/af6ae38f/attachment.html>


More information about the Rpm-maint mailing list