[Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

[Panu Matilainen]

I realize this is a somewhat controversial change of course.

The inspiration comes from discussions on Fedora devel list surrounding the new behavior of strict buildroot content checking (commit c1ca2e35025698328edcefa8dedee866d2ea0596 and 1110c280639b66c89da19a0f831af28845591997) which revealed cases where %check is run on buildroot content, introducing artifacts which then need to be %excluded.

Because the current slot of %check technically allows and even seems to suggest that, saying "but you shouldn't do that" doesn't cut it. Having %check alter packaged content seems a total no-no though. Eliminating the possibility of misuse is by far the most effective medicine for such matters.

And yes some of this further rationale belongs to the commit message, I'll update it later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618#issuecomment-814756549
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210407/db54d138/attachment.html>