[Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

Kalev Lember notifications at github.com
Wed Apr 7 10:55:53 UTC 2021


Would it make sense to change `%check` as the PR here does, and at the same time also add a `%check_buildroot` or something that's the equivalent of the current `%check` and runs after `%install`? This would make it possible to both have a check section that is  appropriate for `make check`, and also make it possible to check what gets installed.

Even that may be too invasive, or at least requires a provenpackager to drive the work and do mass changes in all of the spec files. For instance, we have packaging guidelines in Fedora that mandate the use of desktop-file-validate and appstream-util validate-relax to check the files that got installed in the buildroot, which affects pretty much all GUI apps. This certainly needs someone to go and mass update all of the affected spec files if %check ends up being changed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618#issuecomment-814815875
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210407/78ffcc41/attachment.html>


More information about the Rpm-maint mailing list