[Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

[Vít Ondruch]

I disagree with the specific proposal, because currently, running `%check` after `%install` allows me to not bother with pollution of the `buildroot` directory, e.g. with some temporary files needed to execute the test suite. However, I like @ffesti proposal to run the `%check` even later in the process for two reasons:

1) It would actually allow to run the test suite in the `buildroot`. This would also provide very good place for running the test suite at least in the context of rubygem- packages.
2) I would know much earlier, that I have some (un)packaged files I need to take care prior spending time figuring out issues with the test suite. Someone could admit, that the test suite ensures the `buildroot` content is correct, but that is not true.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618#issuecomment-814945167
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210407/68a560f8/attachment.html>