[Rpm-maint] [rpm-software-management/rpm] Macro file comment loading "regression" (#1659)

Michael Schroeder notifications at github.com
Tue Apr 27 11:30:19 UTC 2021


If you don't mind rdcl() reaching an even higher level of ugliness, an easy fix
is to add
```
        if (p == buf) {
            while (*p && isblank(*p))
                p++;
            if (*p != '%') {
                *q = '\0';              /* trim trailing \r, \n */
                break;
            }    
        }
```
right before the `for (; p < q; p++) {` loop.

This only does the "add continuation lines" magic for real macro definitions.

A different thing to consider is if we want to revert the "empty line ends macro definition"
change, just to make runaway macros not wreck havoc.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1659#issuecomment-827535098
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210427/6063861f/attachment.html>


More information about the Rpm-maint mailing list