[Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

Michael Schroeder notifications at github.com
Fri Feb 5 15:49:14 UTC 2021


@mlschroe commented on this pull request.



> @@ -5,8 +5,8 @@ EXTRA_DIST = \
 
 AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I.
 
-libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@
-libluaext_la_LIBADD = @LUA_LIBS@
+libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX $(LUA_CFLAGS)
+libluaext_la_LIBADD = $(LUA_LIBS)
 libluaext_la_SOURCES = \

What's with this change? The rest of the code still uses the @LUA_XXX@ syntax, so why is this done here?
(ZSTD_XXX is the other odd candidate here) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#pullrequestreview-584464103
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210205/5cee5f85/attachment.html>


More information about the Rpm-maint mailing list