[Rpm-maint] [rpm-software-management/rpm] Avoid incrementing a pointer past the end (#1489)

Panu Matilainen notifications at github.com
Tue Feb 16 12:56:24 UTC 2021


@pmatilai commented on this pull request.



> @@ -394,10 +394,16 @@ static inline int strtaglen(const char *str, rpm_count_t c, const char *end)
     const char *s;
 
     if (end) {
-	if (str >= end)
+	if (start >= end)

Hmm, doesn't the newly added condition below make this check entirely redundant?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1489#pullrequestreview-591197101
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210216/0c737e24/attachment.html>


More information about the Rpm-maint mailing list