[Rpm-maint] [rpm-software-management/rpm] Ensure ELF files get stripped when debuginfo is disabled (#1480)

[Panu Matilainen]

Depending on libmagic version, PIE executables can be reported as
"shared object" avoiding the strip. And so will any libraries because
we're explicitly skipping them for whatever historical reason - perhaps
because there's a separate script for stripping the libraries, but that
has been never enabled in rpm, and relying on "file" strings to do this
is hopelessly unreliable.

Also drop file permissions checks: making shared libraries executable
just to have them stripped is not sensical, especially in the light of
commit 80818e4f902ba3cf85e4cfcd8a7a4c71c601f3cf

Reported once upon time as RhBug:988812 and later RhBug:1634084
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1480

-- Commit Summary --

  * Ensure ELF files get stripped when debuginfo is disabled
  * Drop unused brp-strip-shared buildroot policy script

-- File Changes --

    M platform.in (1)
    M scripts/Makefile.am (4)
    M scripts/brp-strip (4)
    D scripts/brp-strip-shared (25)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1480.patch
https://github.com/rpm-software-management/rpm/pull/1480.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1480
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210108/9f8d8db1/attachment.html>