[Rpm-maint] [rpm-software-management/rpm] Arrange different timestamp for %changelog entries from the same day (#1511)

[Panu Matilainen]

The traditional %changelog entry format produces identical timestamp
(UTC noon) for entries from the same day. Us humans are mostly interested
in the relative chronological order of things, manually inserting
second-precision timestamps for spec changes is just absurd.
However when the topmost changelog entry is used for setting
SOURCE_DATE_EPOCH for reproducable builds, those identical timestamps
for obviously different builds become problematic.

Automatically differentiate the timestamps from the same day by one second
each, starting from noon this allows for over 43000 entries per day. To
ensure reproducable results, we need to walk the entries in the opposite
order to how we originally parse them, complicating things a little.

This allows the traditional changelog format to be used for reproducable
builds in a meaningful manner, without unnecessarily forcing the cumbersome
and problematic full timestamp format everywhere.

[1] https://pagure.io/rpmdevtools/issue/63
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1715412,
    https://github.com/rpm-software-management/rpm/pull/739
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1511

-- Commit Summary --

  * Arrange different timestamp for %changelog entries from the same day

-- File Changes --

    M build/parseChangelog.c (35)
    M tests/Makefile.am (1)
    A tests/data/SPECS/chlog.spec (23)
    M tests/rpmspec.at (25)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1511.patch
https://github.com/rpm-software-management/rpm/pull/1511.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1511
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210120/c06192ee/attachment.html>