[Rpm-maint] [rpm-software-management/rpm] [WIP] Added fapolicyd plugin (#1475)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +        if (!S_ISFIFO(s.st_mode)) {
+            rpmlog(RPMLOG_DEBUG, "File: %s exists but it is not a pipe!\n", state->fifo_path);
+            goto bad;
+        }
+
+        /* keep only file's permition bits */
+        mode_t mode = s.st_mode & ~S_IFMT;
+
+        /* we require pipe to have 0660 permission */
+        if (mode != 0660) {
+        
+            rpmlog(RPMLOG_ERR, "File: %s has %o instead of 0660 \n",
+                    state->fifo_path,
+                    mode );
+
+            goto bad;

Using empty lines for grouping and as visual aid is totally okay, but these two seem redundant/to the contrary to me at least.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475#pullrequestreview-577358310
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210127/adc7da5e/attachment.html>