[Rpm-maint] [rpm-software-management/rpm] Make the rpmdb keyring type macro-configurable (#1575)

Panu Matilainen notifications at github.com
Thu Mar 11 10:13:43 UTC 2021


@pmatilai commented on this pull request.



> @@ -378,13 +378,18 @@ static void loadKeyring(rpmts ts)
     /* Never load the keyring if signature checking is disabled */
     if ((rpmtsVSFlags(ts) & RPMVSF_MASK_NOSIGNATURES) !=
 	RPMVSF_MASK_NOSIGNATURES) {
+	char *kt = rpmExpand("%{?_keyring}", NULL);

I'm a firm believer in many of kernel coding style principles, including naming: https://www.kernel.org/doc/html/v5.11/process/coding-style.html#naming 

It's a local temporary variable and doesn't carry any great big logic in it ... but making the name a *little* longer doesn't hurt and besides, you asked nicely :innocent:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1575#discussion_r592231024
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210311/fc43cb13/attachment.html>


More information about the Rpm-maint mailing list