[Rpm-maint] [rpm-software-management/rpm] Drop extra newlines from spec parser messages (#1591)

Panu Matilainen notifications at github.com
Mon Mar 29 12:21:32 UTC 2021


FYI, a PR with failed checks will generally not get much attention. This looks like it just needs some test output updated to the new reality. That case is actually a good argument for the change, the newline(s) make no sense at all.

I'm inclined to think the format string should be in charge of the formatting though, rather than content. There may be cases where you want to omit the newline, and a missing `\n` in printf/log message strings tends to look like, and usually is, a bug. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1591#issuecomment-809332797
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210329/bb89b9ce/attachment.html>


More information about the Rpm-maint mailing list