[Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

Panu Matilainen notifications at github.com
Tue May 25 09:00:06 UTC 2021


@pmatilai commented on this pull request.



> +    dbcookie = rpmdbCookie(rpmtsGetRdb(ts));
+    if (!dbus_message_append_args(msg, DBUS_TYPE_STRING, &dbcookie)) {
+	goto err;
+    }
+    dbcookie = _free(dbcookie);
+
+    if (!dbus_connection_send(state->bus, msg, &serial)) {
+	goto err;
+    }
+    dbus_connection_flush(state->bus);
+    return RPMRC_OK;
+
+ err:
+    rpmlog(RPMLOG_WARNING,
+	   "dbus_announce plugin: Error sending message (%s)\n",
+	   name);

Maybe log the serial number here too since we already have it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#pullrequestreview-667571166
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210525/4f813bd8/attachment.html>


More information about the Rpm-maint mailing list