<p>In <a href="https://github.com/rpm-software-management/rpm/pull/68#discussion_r64628600">rpmio/base64.c</a>:</p>
<pre style='color:#555'>> @@ -104,7 +104,7 @@ static int base64_decode_value(unsigned char value_in)
>  {
>    static const int decoding[] = {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51};
>    value_in -= 43;
> -  if (value_in > sizeof(decoding)/sizeof(int))
> +  if (value_in >= sizeof(decoding)/sizeof(int))
</pre>
<p>my 2 cents: also change to sizeof(decoding)/sizeof(decoding[0])</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/rpm-software-management/rpm/pull/68/files/0964912b94f9f48a0a812fbfbb2f996dbd93eff0#r64628600">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/ANb8010EA2ZEhsk2M9eS55siNv9iXsFbks5qFJdpgaJpZM4ImcEm.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/68/files/0964912b94f9f48a0a812fbfbb2f996dbd93eff0#r64628600"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>