<p><b>@ldv-alt</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16280889">scripts/brp-remove-libtool-files</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,14 @@
+#!/bin/sh
+
+# If using normal root, avoid changing anything.
+if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then
+       exit 0
+fi
+
+find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la  -print0 |
+xargs  --no-run-if-empty -0 file -N -L |
+grep "libtool library file" |
+sed -e 's#: libtool library file.*##g' |
</pre>
<p>grep followed by sed? Really? Is it an accepted shell scripting style nowadays?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16280889">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb808lViOXGrPv7lr9u9BMxYXCYExS7ks5rRZM4gaJpZM4LhDpA">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb800rpZY6LqDS98z5mih4ev8YZzWV7ks5rRZM4gaJpZM4LhDpA.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16280889"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ldv-alt requested changes on #122"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16280889"}}}</script>