<p>After wasting time looking at the obviously completely untested patch against an imaginary library in PR <a href="https://github.com/rpm-software-management/rpm/pull/117" class="issue-link js-issue-link" data-url="https://github.com/rpm-software-management/rpm/issues/117" data-id="199111818" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#117</a> ... to put it really really politely, I'm not in a very positive mood towards this work.</p>
<p>I'm not going to look at a single patch until you show me some numbers to back up the change, for each compression type/program separately on traditional spinning harddisk, SSD numbers as an added bonus. In rpmbuild context to show you've actually tested it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/126#issuecomment-272401511">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb807M1XucPdnmFsm1wiBm7ZpYtLnpVks5rR0chgaJpZM4Linvq">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb80-E98VN6c0ciYVymQpHpp8UI2QcTks5rR0chgaJpZM4Linvq.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/126#issuecomment-272401511"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pmatilai in #126: After wasting time looking at the obviously completely untested patch against an imaginary library in PR #117 ... to put it really really politely, I'm not in a very positive mood towards this work.\r\n\r\nI'm not going to look at a single patch until you show me some numbers to back up the change, for each compression type/program separately on traditional spinning harddisk, SSD numbers as an added bonus. In rpmbuild context to show you've actually tested it."}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/126#issuecomment-272401511"}}}</script>