<p><b>@ignatenkobrain</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/129#pullrequestreview-17256328">configure.ac</a>:</p>
<pre style='color:#555'>> +WITH_OPENSSL_INCLUDE=
+WITH_OPENSSL_LIB=
+if test "$with_openssl" = yes; then
+# If we have pkgconfig make sure CPPFLAGS are setup correctly for the OpenSSL
+# -I include path.
+AC_PATH_TOOL([PKGCONFIG], [pkg-config], [no], [$PATH:/usr/bin:/usr/local/bin])
+if test "x$PKGCONFIG" != "xno"; then
+  CPPFLAGS="$CPPFLAGS $($PKGCONFIG --cflags libcrypto)"
+fi
+
+AC_CHECK_HEADERS([openssl/evp.h], [], [
+  AC_MSG_ERROR([missing required OpenSSL header])
+])
+
+AC_CHECK_LIB(crypto, EVP_DigestInit_ex, [
+  WITH_OPENSSL_LIB=$($PKGCONFIG --libs libcrypto)
</pre>
<p>I think this will crash if --with-openssl is set, but pkg-config is not found</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/129#pullrequestreview-17256328">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80wYl0V1UNyuIovgnULTGdgZQzdq7ks5rTjcrgaJpZM4LnDnN">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb803PnXkUyZAYf_w9dKzbW99YslDH0ks5rTjcrgaJpZM4LnDnN.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/129#pullrequestreview-17256328"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ignatenkobrain commented on #129"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/129#pullrequestreview-17256328"}}}</script>