<p>Oh, I know about the patches_num patch. I don't much like it, and thought ordinals aren't that helpful. Which is why there are no backups currently. I was kinda hoping you guys had come up with some nicer way to generate backups with patch numbers when I saw this ;)</p>
<p>Anyway, on a second thought - if you're stuck on a desert island with nothing but patch and gendiff, backups by ordinal are <em>worlds</em> better than nothing at all.</p>
<p>As for the implementation, I think it'd be better to pass the ordinal as-is to the backends who are free to do whatever they wish (including ignore) the additional information. Rather than force a specific patch-backup oriented format all the way at the top, that is. It also relies on quirks in the rpm macro system (referring to an option passed to a calling macro) and breaks at least the quilt backend (because of that).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you were mentioned.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/109#issuecomment-273470825">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb805XPmw_etnPi3pHSiRlc0M97jn1Mks5rTg7ggaJpZM4LIiHk">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb801yPS9IfyPhIKNy-9vvYOGr-VpWjks5rTg7ggaJpZM4LIiHk.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/109#issuecomment-273470825"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pmatilai in #109: Oh, I know about the patches_num patch. I don't much like it, and thought ordinals aren't that helpful. Which is why there are no backups currently. I was kinda hoping you guys had come up with some nicer way to generate backups with patch numbers when I saw this ;)\r\n\r\nAnyway, on a second thought - if you're stuck on a desert island with nothing but patch and gendiff, backups by ordinal are *worlds* better than nothing at all.\r\n\r\nAs for the implementation, I think it'd be better to pass the ordinal as-is to the backends who are free to do whatever they wish (including ignore) the additional information. Rather than force a specific patch-backup oriented format all the way at the top, that is. It also relies on quirks in the rpm macro system (referring to an option passed to a calling macro) and breaks at least the quilt backend (because of that)."}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/109#issuecomment-273470825"}}}</script>