<p><b>@proyvind</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/122#discussion_r101492731">scripts/brp-remove-rpath</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,49 @@
+#!/bin/sh
+
+# This script makes sure to remove any standard library search paths from rpath
+# or runpath tags as they're not only redundant, but will break overriding
+# search paths. Search paths of the tag that's not standard will be kept intact.
+
+# If using normal root, avoid changing anything.
+if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then
+       exit 0
+fi
+
+# make sure we have chrpath in our search path, otherwise wuzz out
+type chrpath || exit 0
</pre>
<p>You misunderstand the script's purpose.<br>
It doesn't unconditionally remove all rpaths, but rather rpaths for standard search directories such as ie. /usr/lib64 as rpath, which first of all doesn't make sense, secondly it takes presence over $LD_LIBRARY_PATH, breaking the possibility for overriding default search path for binaries with such rpaths.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/122#discussion_r101492731">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb808gzAfxH6kFiXMINv5ZOpJ0I2Vd6ks5rdCu7gaJpZM4LhDpA">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb80zdtBvJbcTLLdIIV_kyevHGAqYCVks5rdCu7gaJpZM4LhDpA.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/122#discussion_r101492731"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@proyvind commented on #122"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/122#discussion_r101492731"}}}</script>