<p><a href="https://github.com/ffesti" class="user-mention">@ffesti</a>, I wrote couple of testcases for "with" op and looks like it doesn't work in some cases</p>
<pre><code>208: unsatisfied WITH require                        ok
209: satisfied WITH require                          ok
210: unsatisfied nested WITH-AND require             FAILED (rpmdeps.at:851)
211: satisfied nested WITH-AND require               FAILED (rpmdeps.at:877)
212: unsatisfied nested WITH-OR require              ok
213: satisfied nested WITH-OR require                ok
214: unsatisfied nested WITH-IF require              ok
215: satisfied nested WITH-IF require - not featured FAILED (rpmdeps.at:983)
216: satisfied nested WITH-IF require - full chain   FAILED (rpmdeps.at:1006)
217: unsatisfied nested WITH-IF-ELSE require         ok
218: satisfied nested WITH-IF-ELSE require - left clause FAILED (rpmdeps.at:1061)
219: satisfied nested WITH-IF-ELSE require - right clause ok
</code></pre>
<ul>
<li><code>WITH-AND</code> is intentional, but I think we should allow it and internally translate to <code>WITH-WITH</code></li>
<li><code>WITH-IF</code> doesn't understand that right clause is kinda optional</li>
<li><code>WITH-IF-ELSE</code> does something weird wither left clause of <code>IF</code></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/164#issuecomment-281974663">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80010wwFl6vUFZoQ6saMwZpD9Q5Emks5rfXXKgaJpZM4MJ1Jq">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb806r8wHtyURgCSC2ViSgaplJiwrxLks5rfXXKgaJpZM4MJ1Jq.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/164#issuecomment-281974663"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ignatenkobrain in #164: @ffesti, I wrote couple of testcases for \"with\" op and looks like it doesn't work in some cases\r\n\r\n```\r\n208: unsatisfied WITH require                        ok\r\n209: satisfied WITH require                          ok\r\n210: unsatisfied nested WITH-AND require             FAILED (rpmdeps.at:851)\r\n211: satisfied nested WITH-AND require               FAILED (rpmdeps.at:877)\r\n212: unsatisfied nested WITH-OR require              ok\r\n213: satisfied nested WITH-OR require                ok\r\n214: unsatisfied nested WITH-IF require              ok\r\n215: satisfied nested WITH-IF require - not featured FAILED (rpmdeps.at:983)\r\n216: satisfied nested WITH-IF require - full chain   FAILED (rpmdeps.at:1006)\r\n217: unsatisfied nested WITH-IF-ELSE require         ok\r\n218: satisfied nested WITH-IF-ELSE require - left clause FAILED (rpmdeps.at:1061)\r\n219: satisfied nested WITH-IF-ELSE require - right clause ok\r\n```\r\n\r\n* `WITH-AND` is intentional, but I think we should allow it and internally translate to `WITH-WITH`\r\n* `WITH-IF` doesn't understand that right clause is kinda optional\r\n* `WITH-IF-ELSE` does something weird wither left clause of `IF`"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/164#issuecomment-281974663"}}}</script>