<p>Grrr 32 * 8 = 256Kb ...</p>
<p>I can post an updated patch if that helps merging. The amount of code involved is quite small (and is perfectly obvious: move fdatasync out of the loop, perform before advise()).</p>
<p>I doubt that better than fallocate -> Fwrite-in-loop -> fdatasync+fadvise+fsync is possible since a single fdatasync seems better than fdatasync after every write.</p>
<p>Note that 17x is much better than 50x slower from a naive "opt-in" fsync</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/187#issuecomment-294227353">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80yWxdRrhC65SuojUdt5n2wWsNWSOks5rv9L1gaJpZM4MyLOi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb802HvVzCh7F-HYHFJnXGAFiehVTF3ks5rv9L1gaJpZM4MyLOi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/187#issuecomment-294227353"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@n3npq in #187: Grrr 32 * 8 = 256Kb ... \r\n\r\nI can post an updated patch if that helps merging. The amount of code involved is quite small (and is perfectly obvious: move fdatasync out of the loop, perform before advise()).\r\n\r\nI doubt that better than fallocate -\u003e Fwrite-in-loop -\u003e fdatasync+fadvise+fsync is possible since a single fdatasync seems better than fdatasync after every write.\r\n\r\nNote that 17x is much better than 50x slower from a naive \"opt-in\" fsync"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/187#issuecomment-294227353"}}}</script>