<p>This PR includes <a href="https://github.com/rpm-software-management/rpm/pull/122" class="issue-link js-issue-link" data-url="https://github.com/rpm-software-management/rpm/issues/122" data-id="200204902" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#122</a> and attempts to address the remaining feedback.</p>
<p>So far, the following changes have been made:</p>
<ul>
<li>pkgconfig manipulation was dropped. The script wasn't even included in <a href="https://github.com/rpm-software-management/rpm/pull/122" class="issue-link js-issue-link" data-url="https://github.com/rpm-software-management/rpm/issues/122" data-id="200204902" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#122</a>, and it's not clear it was a desirable change, anyway.</li>
<li>'dont' was changed to 'disable', to be more consistent with other things in rpm</li>
<li>all brp scripts are now marked as executable, so that they would actually run</li>
<li>Small change in the comment in <code>brp-remove-rpath</code></li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/rpm-software-management/rpm/pull/230'>https://github.com/rpm-software-management/rpm/pull/230</a></p>
<h4>Commit Summary</h4>
<ul>
<li>add helper script for automatically cleaning backup files from buildroot</li>
<li>add brp script for removing any /usr/share/info/dir files created</li>
<li>add helper script for automatically relativizing symlinks in buildroot</li>
<li>add helper script for removing libtool .la files from buildroot</li>
<li>add brp script for automatically converting DOS to UNIX style EOL</li>
<li>add brp script for removing standard search paths from rpaths</li>
<li>add brp script for enforcing correct permissions for certain files</li>
<li>add brp script for automatically fixing non-XDG compliant .desktop files</li>
<li>add brp script for automatically creating library symlinks using ldconfig</li>
<li>add brp script to check elf files unused libs</li>
<li>add script for checking elf files for undefined symbols</li>
<li>add disablers for existing brp- scripts</li>
<li>Change 'dont' to 'disable' for brp script flags</li>
<li>Make all brp-* scripts executable</li>
<li>brp-remove-rpath: change "wuzz out" to "quit" in comment</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-0">platform.in</a>
(19)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-1">scripts/Makefile.am</a>
(10)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-2">scripts/brp-check-elf-files-for-undefined-symbols</a>
(31)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-3">scripts/brp-check-elf-files-for-unused-libraries</a>
(33)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-4">scripts/brp-clean-files</a>
(37)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-5">scripts/brp-fix-desktop-files</a>
(17)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-6">scripts/brp-fix-eol</a>
(16)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-7">scripts/brp-fix-file-permissions</a>
(33)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-8">scripts/brp-java-gcjcompile</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-9">scripts/brp-python-bytecompile</a>
(0)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-10">scripts/brp-relink-symlinks</a>
(30)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-11">scripts/brp-remove-info-dir</a>
(15)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-12">scripts/brp-remove-libtool-files</a>
(14)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-13">scripts/brp-remove-rpath</a>
(49)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/rpm-software-management/rpm/pull/230/files#diff-14">scripts/brp-strip-shared</a>
(0)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/rpm-software-management/rpm/pull/230.patch'>https://github.com/rpm-software-management/rpm/pull/230.patch</a></li>
<li><a href='https://github.com/rpm-software-management/rpm/pull/230.diff'>https://github.com/rpm-software-management/rpm/pull/230.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/230">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80_IQiK_V7twA0OAo71a5Q2duAp5sks5r__KpgaJpZM4NuKjx">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb80_4OSgpQIR1nUFU7RMTaSAYy99x1ks5r__KpgaJpZM4NuKjx.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/230"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"WIP: Add brp helper scripts derived from spec-helper (#230)"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/230"}}}</script>