<p><b>@ignatenkobrain</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/rpm-software-management/rpm/pull/225#discussion_r119803606">rpmio/rpmlog.c</a>:</p>
<pre style='color:#555'>> @@ -237,6 +237,89 @@ const char * rpmlogLevelPrefix(rpmlogLvl pri)
     return prefix;
 }
 
+static const char * rpmlogLevelColor(rpmlogLvl pri)
+{
+    return rpmlogMsgPrefixColor[pri&0x7];
+}
+
+static int rpmlogDefault(FILE *stdlog, rpmlogRec rec)
+{
+    static const char fubar[] =
+       "Error occurred during writing of a log message";
+    FILE *msgout = (stdlog ? stdlog : stderr);
+    const char * colorOn = isatty(fileno(msgout))
</pre>
<p>I would prefer to have some macro/option to force enabling/disabling colors (like a --color[=WHEN] where WHEN is "auto", "always", "never")...</p>
<p>because when you would be passing that to <code>less</code>, you could pass <code>-R</code> and it will show you colors in pager... Quite useful.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-41716172">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb809e7DELyTxGvuXaegRdyJlcbWvo6ks5r_8VvgaJpZM4NsBEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb805M21I-oD9-ZXHoyx1EMdUI9U0Mrks5r_8VvgaJpZM4NsBEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-41716172"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ignatenkobrain commented on #225"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-41716172"}}}</script>