<p>You even caught some design shortcomings of rpm. and improved on poor implementations, bravo!</p>
<p>While only having quickly reviewed code, (but having knowledge of openmp and code in question at leastt), only thing I can come to think of is more aestetics, ie.</p>
<ul>
<li>#pragma omp critical(rpmstrpool)</li>
<li>{<br>
if (pool && sid > 0 && sid <= pool->offs_size) {<br>
slen = strlen(pool->offs[sid]);<br>
}</li>
<li>}</li>
</ul>
<pre><code>#pragma omp critical(rpmstrpool) {
    if (pool && sid > 0 && sid <= pool->offs_size) {
    slen = strlen(pool->offs[sid]);
    }
}
</code></pre>
<p>would be more readable IMO.</p>
<p>But wars can't possible have started by less, so I give my approval after giving a first sight. <g-emoji alias="+1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png" ios-version="6.0">👍</g-emoji>  :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/226#issuecomment-307423819">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb801D78fXVab_CVo8FwV88PRJmMPOAks5sCWdtgaJpZM4NtKT8">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb802q2pPNeMyR6DH3myJr63zEYlNE7ks5sCWdtgaJpZM4NtKT8.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/226#issuecomment-307423819"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@proyvind in #226: You even caught some design shortcomings of rpm. and improved on poor implementations, bravo!\r\n\r\nWhile only having quickly reviewed code, (but having knowledge of openmp and code in question at leastt), only thing I can come to think of is more aestetics, ie.\r\n+    #pragma omp critical(rpmstrpool)\r\n+    {\r\n     if (pool \u0026\u0026 sid \u003e 0 \u0026\u0026 sid \u003c= pool-\u003eoffs_size) {\r\n        slen = strlen(pool-\u003eoffs[sid]);\r\n     }\r\n+    }\r\n\r\n    #pragma omp critical(rpmstrpool) {\r\n        if (pool \u0026\u0026 sid \u003e 0 \u0026\u0026 sid \u003c= pool-\u003eoffs_size) {\r\n        slen = strlen(pool-\u003eoffs[sid]);\r\n        }\r\n    }\r\n\r\nwould be more readable IMO.\r\n\r\nBut wars can't possible have started by less, so I give my approval after giving a first sight. :+1:  :)"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/226#issuecomment-307423819"}}}</script>