<p>Right now <code>make check</code> returns success exit status: 0 when the tests are failed.</p>
<pre><code>$ make check
...
## ------------- ##
## Test results. ##
## ------------- ##

ERROR: All 358 tests were run,
21 failed (2 expected failures).
## ------------------------- ##
## rpmtests.log was created. ##
## ------------------------- ##
...
</code></pre>
<pre><code>$ echo $?
0
</code></pre>
<p>Because the logic to succeed forcely is added below commit.<br>
But I think that it is not good. Because we can not detect failed tests for example in <code>rpm.spec</code> check section.</p>
<p><a href="https://github.com/rpm-software-management/rpm/commit/52bc67436f5bc28d2bd08a9fd3498cf16d5817bb" class="commit-link"><tt>52bc674</tt></a></p>
<p>After this modification, <code>make check</code> returns error exit status.</p>
<pre><code>$ make check
...
## ------------- ##
## Test results. ##
## ------------- ##  

ERROR: All 358 tests were run,
21 failed (2 expected failures).
## ------------------------- ##
## rpmtests.log was created. ##
## ------------------------- ##
...
</code></pre>
<pre><code>$ echo $?
2
</code></pre>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/rpm-software-management/rpm/pull/248'>https://github.com/rpm-software-management/rpm/pull/248</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Return error exit status when make check is failed.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/rpm-software-management/rpm/pull/248/files#diff-0">tests/Makefile.am</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/248.patch'>https://github.com/rpm-software-management/rpm/pull/248.patch</a></li>
  <li><a href='https://github.com/rpm-software-management/rpm/pull/248.diff'>https://github.com/rpm-software-management/rpm/pull/248.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/248">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80yd4NEMhoDQkMQD4ZDBa9ahw9mCdks5sKQUkgaJpZM4OMaRv">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb805wvDRnxj2hoWv-mn-emcNgpMg7jks5sKQUkgaJpZM4OMaRv.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/248"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Return error exit status when make check is failed. (#248)"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/248"}}}</script>