<p><b>@ignatenkobrain</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/rpm-software-management/rpm/pull/263#discussion_r128895057">macros.in</a>:</p>
<pre style='color:#555'>> @@ -942,7 +942,7 @@ package or when debugging this package.\
%_sharedstatedir %{_prefix}/com
%_localstatedir %{_prefix}/var
%_lib lib
-%_libdir %{_exec_prefix}/%{_lib}
+%_libdir @libdir@
</pre>
<p>+1</p>
<hr>
<p>In <a href="https://github.com/rpm-software-management/rpm/pull/263#discussion_r128895061">rpm.am</a>:</p>
<pre style='color:#555'>> @@ -1,10 +1,10 @@
# Internal binaries
## HACK: It probably should be $(libexecdir)/rpm or $(libdir)/rpm
-rpmlibexecdir = $(prefix)/lib/rpm
+rpmlibexecdir = $(libdir)/rpm
</pre>
<p>+1</p>
<hr>
<p>In <a href="https://github.com/rpm-software-management/rpm/pull/263#discussion_r128895065">configure.ac</a>:</p>
<pre style='color:#555'>> @@ -1005,7 +1005,7 @@ else
usrprefix=$prefix
fi
-RPMCONFIGDIR="`echo ${usrprefix}/lib/rpm`"
+RPMCONFIGDIR="`echo ${libdir}/rpm`"
</pre>
<p>We probably should really use libexecdir</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/263#pullrequestreview-51621002">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb807KWmLXg0iWqMHmE8AjAJpAPKackks5sQdnbgaJpZM4Od8PQ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb805TbH_3vd15L_EDTkcqlJk3NpGmPks5sQdnbgaJpZM4Od8PQ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/263#pullrequestreview-51621002"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ignatenkobrain requested changes on #263"}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/263#pullrequestreview-51621002"}}}</script>