<p>Eek, that's horrible. Please add a way (macro) to disable this.</p>
<p>Calling sync() hurts very much for big servers with huge disks and a big buffer cache. I get that's it's somewhat acceptable for software installation on the server (syncfs would still be much nicer so that data partitions don't get synced). But what you're forgetting is chroot installations like done by mock or container package installation done by dockerd.</p>
<p>E.g. this would severely slow down open build service workers.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110006">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb8046XzXl96KhWi6HQmzAuXzB5pbDaks5sflWsgaJpZM4POAZ0">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb8026bYy-wQGjtF8uruyfokrCLnLBLks5sflWsgaJpZM4POAZ0.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110006"></link>
  <meta itemprop="name" content="View Commit"></meta>
</div>
<meta itemprop="description" content="View this Commit on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mlschroe on b7a869f: Eek, that's horrible. Please add a way (macro) to disable this.\r\n\r\nCalling sync() hurts very much for big servers with huge disks and a big buffer cache. I get that's it's somewhat acceptable for software installation on the server (syncfs would still be much nicer so that data partitions don't get synced). But what you're forgetting is chroot installations like done by mock or container package installation done by dockerd.\r\n\r\nE.g. this would severely slow down open build service workers.\r\n"}],"action":{"name":"View Commit","url":"https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110006"}}}</script>