<p><a href="https://github.com/ldv-alt" class="user-mention">@ldv-alt</a> - the thing is, a "use foo on glibc" kind of change doesn't really do anything to get rid of the bundled code because it'll still be needed for other platforms. Instead these things end up <em>adding</em> more burden by introducing another path requiring validation. So when such a change breaks something (even if the something is broken by itself) without actually bringing in any <em>concrete</em> bug fixes or enhancements, pardon me for not jumping up and down in joy in here.</p>
<p>You really want to get rid of the bundled FTS, rewrite it using something that's actually standardized, such as nftw().</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/rpm-software-management/rpm/pull/324#issuecomment-329381608">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ANb80z9Xu7MDZZyUAYKVBDBOEjQK2jNEks5siMBVgaJpZM4PR-u5">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ANb809GjskcXDpV3VpopbaaXWLnyt_sKks5siMBVgaJpZM4PR-u5.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/rpm-software-management/rpm/pull/324#issuecomment-329381608"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/rpm-software-management/rpm","title":"rpm-software-management/rpm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/rpm-software-management/rpm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pmatilai in #324: @ldv-alt - the thing is, a \"use foo on glibc\" kind of change doesn't really do anything to get rid of the bundled code because it'll still be needed for other platforms. Instead these things end up *adding* more burden by introducing another path requiring validation. So when such a change breaks something (even if the something is broken by itself) without actually bringing in any *concrete* bug fixes or enhancements, pardon me for not jumping up and down in joy in here.\r\n\r\nYou really want to get rid of the bundled FTS, rewrite it using something that's actually standardized, such as nftw()."}],"action":{"name":"View Pull Request","url":"https://github.com/rpm-software-management/rpm/pull/324#issuecomment-329381608"}}}</script>